Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change uuid dependency to community maintained fork #3

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Change uuid dependency to community maintained fork #3

merged 1 commit into from
Oct 30, 2020

Conversation

guywithacube
Copy link
Contributor

github.com/gofrs/uuid is no longer being actively maintained
See satori/go.uuid#84 for more detail

The dependency satori/go.uuid causes the following:

$ go get github.com/ivanbeldad/kasa-go
go: github.com/ivanbeldad/kasa-go upgrade => v0.0.0-20191206080011-613ab073653e
go: finding module for package github.com/satori/go.uuid
go: found github.com/satori/go.uuid in github.com/satori/go.uuid v1.2.0
# github.com/ivanbeldad/kasa-go
/Users/guywithacube/go/pkg/mod/github.com/ivanbeldad/[email protected]/auth.go:32:12: assignment mismatch: 2 variables but uuid.NewV4 returns 1 values

Following the advice from satori/go.uuid#84, I think it would be wise to move towards an actively maintained fork.

@guywithacube
Change uuid dependency to community maintained fork
6e3987b 
github.com/gofrs/uuid is no longer being actively maintained
See satori/go.uuid#84 for more detail
@ivanbeldad ivanbeldad merged commit e56d459 into ivanbeldad:master Oct 30, 2020
@ivanbeldad
Copy link
Owner

Merged, thank you @guywithacube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guywithacube @ivanbeldad